docs: minor update to use pickN CRP for eviction how-to doc#1099
Merged
Arvindthiru merged 1 commit intoAzure:mainfrom Mar 26, 2025
Merged
docs: minor update to use pickN CRP for eviction how-to doc#1099Arvindthiru merged 1 commit intoAzure:mainfrom
Arvindthiru merged 1 commit intoAzure:mainfrom
Conversation
Contributor
Author
|
The change is address the case where a PickAll CRP with more than one member cluster joined will always be available https://github.com/Azure/fleet/blob/main/docs/howtos/eviction-placement-disruption-budget.md?plain=1#L85 (In the How-to I created a fleet with only one member cluster joined) Hence using PickN CRP to be deterministic |
jwtty
reviewed
Mar 26, 2025
| numberOfClusters: 1 | ||
| ``` | ||
|
|
||
| The `CRP` status after applying should look something like this: |
Contributor
There was a problem hiding this comment.
Why does the crp example on line 41 and below have GEN 2?
Contributor
There was a problem hiding this comment.
Looks like the GEN is 2 "magically" for a pickN CRP. Need to investigate more on it.
jwtty
approved these changes
Mar 26, 2025
ryanzhang-oss
pushed a commit
to ryanzhang-oss/fleet
that referenced
this pull request
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer